OpenZeppelin reviewed Compound proposal #345, which initializes an AERO Comet market on Base with USDC, WETH, wstETH and cbBTC as collateral assets.
We have identified the following low-severity issues:
-
The use of a
ScalingPriceFeed
for the base asset AERO, as well as the collateral assets USDC, WETH, and cbBTC, is unnecessary. The underlying price feeds are already in 8 decimal places, and using theScalingPriceFeed
would result in increased gas costs. -
The price feed for the
wstETH
collateral combines awstETH
tostETH
price feed with aETH
toUSD
price feed to pricewstETH
inUSD
assuming a 1:1 exchange rate betweenstETH
andETH
. While the use of exchange rates for LSTs has been discussed and approved in a snapshot vote, the proposal, forum post, snapshot vote, and parameter recommendations discussion do not disclose the assumption or justify its risks explictly. The proposed price feed configuration is inconsistent with other Comet markets usingwstETH
as collateral, such as the Mainnet USDC Comet, which use an underlyingstETH
toETH
price feed. -
The market will be empty upon initialization as it is not seeded. While this does not pose an immediate security risk, the market should be funded at initialization.