Governance Proposal 22: Borrow Limits Comptroller Patch (Renamed to Borrow Caps)

I plan to deploy the current version of the new Comptroller with borrow limits implemented over the weekend. View the PR here. Assuming the deployment goes as planned and matches successfully, the proposal will be made sometime next week.

Update: Deployed here.

This was a somewhat long process with multiple postings about it:



Following the requests of the community, initially, the new code will be introduced without actually being utilized. The newly made community multisig will be set as the “Borrow Limit Guardian” but will not impose any limits. In future proposals, the limits will be set and the role of the community multisig will be further established.

I have written a test suite and a fork simulating the new proposal to test the new code, and it all checks out. Additionally, the new patch has been the comptroller on Koran for the past few weeks. Please proof read the code yourself before voting on the proposal. The code does not touch any core features of the protocol, so it not been audited professionally.

Another new idea I would like to introduce in this proposal is rewards to users who build on the protocol to encourage further development. In the future, this could be automated by the Governance Alpha contract, but for now, this must be added as additional actions to the proposal. Following recommendations, I propose withdrawing $5000 from the SAI reserves (equivalent to 2360 SAI) to my address as a reward for bringing this feature to reality. I don’t have any precedent to base this number on, so if you think it should be different, say so!

All in all, the planned actions of the proposal are as follows:

  • Unitroller _setPendingImplementation(NewComptroller)
  • NewComptroller _become(Unitroller)
  • Unitroller _setBorrowLimitGuardian(community multisig)
  • cSAI reduceReserves(2360 * 1e18)
  • SAI transfer(Arr00, 2360*1e18)
3 Likes

All good, matched the PR bytecode to the deployed Comptroller contract

Using network mainnet https://mainnet-eth.compound.finance
Matching contract at 0x707b501cbce95c5fdb25005a51f33c5b1aa30607 to Comptroller with args []
:white_check_mark: Successfully matched Comptroller to 0x707b501cbce95c5fdb25005a51f33c5b1aa30607 with args []

1 Like

Prior to creating the proposal, can you verify the steps taken to peer-review or audit the final contract, or get the PR into a “final” state?

This proposal would be include the first community-developed contracts with a self-issued reward (bounty) for the engineering effort – kudos on the creative approach to using protocol reserves.

If the community supports this approach, it could serve as a template for other community-developed protocol upgrades (without requiring a “development fund” or centralized approval).

1 Like

I’m going to attempt to simulate using the deployed contract, I’ll report back here with results.

We won’t be proposing this for the time being. Still working on further testing/auditing. Will be back soon with more updates.

I support this patch, but want to call out that we should not name the upgrade “Borrow Limit” as that term is already well known/used in the interface as an individual’s borrowing limit based on their supply (example - 1 example - 2).

“Borrow Cap” works great :+1:.

1 Like

I was already questioning my word choice as I feel “cap” works better in the macro environment but was reluctant to change this far along. Combined with the chance of confusion, I agree with you. “Borrow Cap” it is.

1 Like

I may have jumped the gun deploying before. I took some more input into account in recent commits from the community, Compound team, and Open Zeppelin audit. Again, please review the most recent commit. I’ll redeploy (hopefully for the last time) this weekend.

2 Likes

The PR is now in a final state with the comments in the audit taken into account. The contract has been redeployed here.

1 Like

I simulated what would happen on mainnet upgrading to 0x7b5e3521a049c8ff88e6349f33044c6cc33c113c, and found that the caps are working as expected, as far as I was able to check. There is a minor increase in gas costs for borrowing (looks about 4K or 1.66%). I checked setting up liquidations / borrows with and without the caps, before and after the upgrade. I also checked that borrows get rejected when they hit against the cap.

To run the simulation above, you will need to run your own ganache, or wait until the ganache on demand service is back up and running (temporarily down).

1 Like

checked the newly deployed contract it does matches with the github PR, all good again.

Using network mainnet https://mainnet-eth.compound.finance
Matching contract at 0x7b5e3521a049c8ff88e6349f33044c6cc33c113c to Comptroller with args []
:white_check_mark: Successfully matched Comptroller to 0x7b5e3521a049c8ff88e6349f33044c6cc33c113c with args []

The proposal is live here. I pushed a post proposal fork simulation to GitHub which shows that the execution will be successful and does some post execution sanity checks.

1 Like

Wondering if there has been any further discussions since the original post around what the borrow limits should be. Seems like we should develop a framework around that.

Yes! Now that the framework to use them is in place we should discuss using it. Let’s take this to another thread.

1 Like